In C++, unlike C, the enum has a variable storage size and isn’t assumed to be int. For this approach, I had originally thought of passing a texture parameter to the Material (which loads the texture) using an enum, but I ran into the issue of having to predeclare the enum when used in places that had also predeclared the Material class. This approach seemed to work well, also resolving all of the issues resolved by the previous patch.

It was at this point that Akz- suggested that I try clamping sprites, which are generally images painted on top of the scene (such as the candles’ flame or the Dainty at dock on Lucre Island) and repeat all other textures. Rats, that approach definitely was wrong! Filtering for Texture EventsĪfter some investigation, I found that there were definitely textures that used clamping when the size was lower than 128 pixels and repeating when greater. To make the trace more manageable, I filtered the results for Texture Events using Trace->Options and configuring it like shown below. With these traces in hand and in the viewer, I took a look at the size of the textures and when the glTexParameteri function was used on them in the retail version. To view the traces, I used the program qapitrace, a GUI viewer for replaying traces from apitrace. Of note, to trace 32-bit Windows applications in wine, you will need a 32-bit version of apitrace. To capture a trace, we’ll use this command with the retail version: To investigate possible solutions, I used apitrace, a tool that records OpenGL state information, allowing you to replay, investigate and examine what OpenGL calls a program is executing to render the screen. There’s nothing that really indicates that that is a cutoff for which approach to take.

Think of a typical grass pattern or a sandy beach texture, or in this case, the lava!Īlthough my approach did fix the problem, the solution was a hack. So why not just always use clamping? Well, in many cases we DO want the texture to repeat. Clamping prevents the OpenGL renderer from repeating the texture over the surface, resulting in lines when the textures don’t repeat cleanly. I had assumed that if a texture was larger than 128 pixels on a side, then that texture should be clamped at the edges. As I indicated in that post, while the work around that I submitted did fix the problem for the scenes with issues, the workaround itself was sort of a hack. In a previous post, I commented on a texturing problem with the lava in the scene lav.

Escape from monkey island residualvm